Repository navigation
fix(oidc): read a missing sessionExchangeEnabled as off - #151
Merged
Merged
Conversation
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.36.0 (#149) made
sessionExchangeEnabledrequired onOidcApplicationSchema. API v0.23 is held, so no running instance sends it yet. A client on 0.36.0 refuses their application responses:seamless clientsfails with "The instance returned an application list this CLI cannot read (applications.0.sessionExchangeEnabled: expected boolean, received undefined)". The failure surfaced when bumping seamless-cli to 0.36.0, and #149's description wrongly called the release additive.The response schema now reads a missing field as
false, which is what it means: an older API has no session exchange. The parsed type staysboolean. Request schemas and the eligibility rule are unchanged.OidcApplicationSchemais the only such field: the new session fields are already optional. The first commit adds the failing test alone. Vitest and typecheck pass locally.