Repository navigation
ci(conformance): hold source builds to the permission guard contract - #355
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
SEAMLESS_VERIFY_CONTRACTS=permission-guardsin the reusable conformance workflow when it builds the SDKs from source, so the Express and Fastify reference apps are held to the permission guard specs. A released run skips them, because a published package may predate the guard.Repos that call this workflow at
main, such as seamless-auth-js, pick this up on merge. Repos that pin an older commit, such as seamless-auth-api and seamless-auth-server, do not until they move the pin.The
verifycheck on this PR is the first CI run of these specs on Express and Fastify. They passed locally against the same code before fells-code/seamless-auth-server#275 merged.Not in this PR: the Next.js job in seamless-auth-server. It pins this CLI at v0.27.2, which predates the specs, so its opt-in waits for the next CLI release.