fix: preserve Unicode regex interpolation provenance - #1143
Closed
fglock wants to merge 1 commit into
Closed
Conversation
Avoid byte-marking an interpolated regex template when it contains Unicode characters, allowing URI::Find's large schemeless URL regex to compile. Fixes #1140 Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
Owner
Author
|
Superseded after user acceptance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qr//is interpolated into a substitution templateValidation
prove src/test/resources/unit/regex/unicode_qr_substitution_template.t./jperl src/test/resources/unit/regex/unicode_qr_substitution_template.t./jperl --interpreter src/test/resources/unit/regex/unicode_qr_substitution_template.tt/Find.t: 578/578 on JVM and interpretermakemake check-linksCloses #1140
Generated with Codex