feat: add /ucan/revoke command#47
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a new UCAN subcommand, /ucan/revoke, by introducing a new argument model and wiring it into the existing command-binding + CBOR/DagJSON codegen pipeline used by the commands/ucan package.
Changes:
- Introduce
RevokeArguments(CID to revoke + revocation path). - Add the
/ucan/revokecommand binding entrypoint. - Extend CBOR + DagJSON generated codecs to include the new argument type.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| commands/ucan/types.go | Adds RevokeArguments model used by the new command. |
| commands/ucan/revoke.go | Registers /ucan/revoke via binding.Bind. |
| commands/ucan/json_gen.go | Adds DagJSON marshal/unmarshal for RevokeArguments. |
| commands/ucan/gen/main.go | Adds RevokeArguments to the codegen model list. |
| commands/ucan/cbor_gen.go | Adds CBOR marshal/unmarshal for RevokeArguments. |
Files not reviewed (2)
- commands/ucan/cbor_gen.go: Generated file
- commands/ucan/json_gen.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frrist
approved these changes
Jul 16, 2026
Comment on lines
+9
to
+12
| type RevokeArguments struct { | ||
| Revoke cid.Cid `cborgen:"revoke" dagjsongen:"revoke"` | ||
| Path []cid.Cid `cborgen:"path" dagjsongen:"path"` | ||
| } |
Member
There was a problem hiding this comment.
Some code comments on what each of these fields are for would be 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/ucan-wg/revocation