Repository navigation
Feature: Moved shared settings and background initialization to the server - #19070
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
@hez2010 do you expect a difference in startup performance? |
Yep. I have split the entire move into 3 PRs, and this is the first one. The other two are smaller because this one lands most work that other two need. We will observe a great startup performance (loading performance, accurately) after the three PRs all merged. This also enables settings, tags, sidebar items sync between Files app instances. For example, changing the settings on a Files instance will now automatically apply to other Files instances immediately, without requiring a restart. |
|
@yair100 PTAL. |
Move settings, tags, startup/session handling, updates to the server and share them between Files instances.
Also, tab icon loads are delayed, and tags on unavailable volumes and access-denied paths are now kept instead of being removed.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.