Skip to content

Feature: Moved shared settings and background initialization to the server - #19070

Merged
yair100 merged 6 commits into
files-community:mainfrom
hez2010:server-state-startup
Oct 28, 2026
Merged

yair100 merged 6 commits into
files-community:mainfrom
hez2010:server-state-startup

Conversation

@hez2010

@hez2010 hez2010 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Move settings, tags, startup/session handling, updates to the server and share them between Files instances.

Also, tab icon loads are delayed, and tags on unavailable volumes and access-denied paths are now kept instead of being removed.

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T01:44:57.895121Z
We couldn’t complete this review. Comment @codex review to try again.
a5cda6c PR opened
🔒 Security Review ⚠️ Failed 2026-10-28T01:44:14.491020Z
We couldn’t complete this review. Comment @codex security review to try again.
a5cda6c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@yair100

yair100 commented Oct 28, 2026

Copy link
Copy Markdown
Member

@hez2010 do you expect a difference in startup performance?

@hez2010

hez2010 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member Author

@hez2010 do you expect a difference in startup performance?

Yep. I have split the entire move into 3 PRs, and this is the first one. The other two are smaller because this one lands most work that other two need.

We will observe a great startup performance (loading performance, accurately) after the three PRs all merged.
The server will start to cache all the things we were manipulating on the startup path, so that subsequent Files app launches only need to query the cache. The cache will keep up-to-date as the server will monitor the changes and propagate incremental updates to all existing Files instances.

This also enables settings, tags, sidebar items sync between Files app instances. For example, changing the settings on a Files instance will now automatically apply to other Files instances immediately, without requiring a restart.

Comment thread src/Files.App/Helpers/Application/AppLifecycleHelper.cs Outdated
Comment thread src/Files.App/Services/App/AppUpdateSideloadService.cs Outdated
Comment thread src/Files.App/Helpers/Navigation/NavigationHelpers.cs
Comment thread src/Files.App.Server/Tags/TagCatalog.cs
@hez2010

hez2010 commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

@yair100 PTAL.

@yair100 yair100 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Oct 28, 2026
@yair100
yair100 merged commit 391214f into files-community:main Oct 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants