Repository navigation
Code Quality: Use PackageReference for vcxproj - #19076
hoshiizumiya wants to merge 4 commits into
Conversation
note: You may need to manually use nuget/visual studio to restore the FilesAppLauncher then delete the old package folder. For example: `nuget restore ".\Files\src\Files.App.Launcher\Files.App.Launcher.vcxproj"`
|
Please read our contribution guidelines. That being said, we'll take a look at this. |
yair100
changed the title
| @@ -1,6 +1,6 @@ | |||
| <!-- Copyright (c) Files Community. Licensed under the MIT License. --> | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- Copyright (c) Files Community. Licensed under the MIT License. --> | |||
There was a problem hiding this comment.
Assuming you're using Codex, don't change the line ending to CRLF to LF. Always run git diff --check
There was a problem hiding this comment.
This is a new line and added xml file's metadata. I'll remove it if you don't want.
| @@ -1,4 +1,4 @@ | |||
| <!-- Copyright (c) Files Community. Licensed under the MIT License. --> | |||
| <!-- Copyright (c) Files Community. Licensed under the MIT License. --> | |||
There was a problem hiding this comment.
This is an UTF-8 BOM change
There was a problem hiding this comment.
@0x5bfa I'll remove it if you want to keep without BOM.
There was a problem hiding this comment.
Looks like it has been LF. Revert the BOM removal and please use CRLF instead.
There was a problem hiding this comment.
Sorry, it's a truly BOM byte adding rather LF. I'll remove it.
There was a problem hiding this comment.
Done, but I want to clarify I never changed the CRLF to CL or used CL line break.🤨
|
|
hez2010
left a comment
hez2010
left a comment
There was a problem hiding this comment.
This LGTM. Thanks!
Also please sign the CLA by clicking the button above so that we can merge this.
Already signed. @hez2010 the bot may meet some trouble.
|
|
|
note: You may need to manually use nuget/visual studio to restore the FilesAppLauncher then delete the old package folder. For example:
nuget restore ".\Files\src\Files.App.Launcher\Files.App.Launcher.vcxproj"Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.