Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the auth/README.md file by adding a new 'Beyond Theming' section to the table of contents and the main text. This section explains how to use FirebaseAuthScreen slot parameters to completely replace screen layouts while keeping the authentication logic, referencing a demo app sample. Additionally, a minor correction was made to remove the '(data class)' label from the .copy() theme customization description. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the auth README's Theming section at the
FirebaseAuthScreenslot APIs, since that section covered restyling but never said whole screens can be replaced.Changes
### Beyond Themingat the end of Theming & Customization, linking Custom UI with Slots and thefullcustomizationdemo, which combines a theme with every slot. Added to the TOC..copy()bullet:AuthUIThemeis a plain class with an explicitcopy.Maintainer note: Fixes internal CPRN-605