refactor(firestore,apple): migrate iOS/macOS plugin implementation to Swift - #18607
refactor(firestore,apple): migrate iOS/macOS plugin implementation to Swift#18607SelaseKay wants to merge 5 commits into
Conversation
… Swift Replace the Objective-C Firestore plugin with a Swift implementation so Apple platforms can use Pigeon swiftOut and the typed pipeline Expression APIs.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
…otes Unregister event channels when streams cancel, avoid capturing self in snapshot listeners, copy snapshot maps without an intermediate array, cap pipeline nesting, and replace forced casts in query parsing with typed errors.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
Description
Migrates the
cloud_firestoreApple plugin from Objective-C to Swift for both iOS and macOS, following the same pattern as packages likefirebase_auth,firebase_core, andfirebase_crashlytics.FLTFirebaseFirestorePluginclass nameobjcOuttoswiftOut(FirestoreMessages.g.swift)Field,Constant,DocumentMatches,Expression.equal(), and so on)SetClientLanguage, which is not callable from SwiftDart, Android, and Windows APIs are unchanged. Plugin users do not need to update their apps.
The
cloud_firestoreiOS pod target was compiled successfully. macOS and Firestore integration tests were not run in this environment. Android Kotlin migration is not part of this PR.Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?