Repository navigation
Conversation
Introduce the Hybrid Image Pattern Finder sample to compare two images and identify shared patterns using hybrid generative AI inference. * Add: `HybridImagePatternViewModel` and `HybridImagePatternUiState` to handle model status checking, downloading, downsampled image decoding, and multi-modal content generation. * Create: `HybridImagePatternScreen` with Compose UI for selecting images via camera or photo picker, choosing inference modes, and viewing analysis results. * Register: `ScreenType.HYBRID_IMAGE_PATTERN` and configure routing in `FirebaseAISamples` and `MainActivity`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables parallel sync for Gradle 9.4+ across multiple modules and introduces a new 'Hybrid Image Pattern Finder' feature in the firebase-ai sample app, allowing users to compare two images and find common patterns using Gemini. Feedback on the implementation highlights two key issues: first, the use of explicit backing fields for uiState in HybridImagePatternViewModel will cause compilation errors because StateFlow does not support the update extension function; second, using TakePicturePreview() in HybridImagePatternScreen returns a low-resolution thumbnail that degrades image analysis quality, so switching to TakePicture() with a temporary file Uri is recommended.
Contributor
|
Tests are failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the Hybrid Image Pattern Finder sample to compare two images
and identify shared patterns using hybrid generative AI inference.
HybridImagePatternViewModelandHybridImagePatternUiStateto handle model status checking, downloading, downsampled image
decoding, and multi-modal content generation.
HybridImagePatternScreenwith Compose UI for selectingimages via camera or photo picker, choosing inference modes, and
viewing analysis results.
ScreenType.HYBRID_IMAGE_PATTERNand configure routing inFirebaseAISamplesandMainActivity.