Repository navigation
chore: update mock plists and update fst readme - #1881
Merged
Merged
Conversation
ncooke3
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces sensitive or specific identifiers, such as API keys, client IDs, and ad unit IDs, with dummy or zeroed values across multiple GoogleService-Info.plist files. It also updates the Firestore setup documentation to use anonymous authentication instead of email/password. The review feedback correctly notes that replacing the official, publicly documented AdMob test ad unit IDs with zeroed dummy values will break out-of-the-box test ad functionality for developers, and recommends retaining the official test IDs.
ncooke3
enabled auto-merge (squash)
October 28, 2026 16:24
paulb777
reviewed
Oct 28, 2026
paulb777
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated secret scanners and code reviews can flag realistic-looking credential strings in checked-in
GoogleService-Info.plistfiles, and the Firestore quickstart README still referenced the removed FirebaseUI dependency.This PR replaces the mock
API_KEY,CLIENT_ID,GOOGLE_APP_ID, andREVERSED_CLIENT_IDvalues across all 18GoogleService-Info.plistfiles with structural placeholders that still satisfyFIROptions/FIRInstallationsformat validation, retains and documents Google's official public AdMob test ad unit IDs so test ads continue loading out of the box, and updates the Firestore README to reflect directFirebaseAuthanonymous sign-in.