Repository navigation
fix(ci): consolidate setup_simulator action to firebase-ios-sdk - #1887
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the temporary local simulator setup script (scripts/setup_simulator.sh), the corresponding GitHub Actions composite action, and the conditional block in scripts/test.sh that automatically ran the simulator setup. There are no review comments, so I have no feedback to provide.
paulb777
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1882, #1886, and firebase/firebase-ios-sdk#16974.
Now that upstream
firebase/firebase-ios-sdkresolvesscripts/setup_simulator.shvia$GITHUB_ACTION_PATHand includes the runtime/duplicate-simulator hardening, this PR:.github/workflows/*.ymlworkflows to referencefirebase/firebase-ios-sdk/.github/actions/setup_simulator@e1e760d7ab3a985cd590f284ad632afc7d192924..github/actions/setup_simulator/action.ymlandscripts/setup_simulator.sh(along with the fallback invocation inscripts/test.sh).