Conversation
…s tuple" This reverts commit 949523f.
…ter and local variable names
ctreffs
enabled auto-merge (squash)
August 24, 2026 08:56
ctreffs
disabled auto-merge
August 24, 2026 08:57
ctreffs
enabled auto-merge (squash)
August 24, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Context
This PR updates
.swiftlint.ymland.swiftformatto preserve explicit type annotations (critical for Swift compiler type-checker optimization) and resolves all 113 SwiftLint warnings/violations across theSources/FirebladeMathcodebase without altering any public APIs.What & Why
Linter & Formatter Configuration:
redundant_type_annotationin.swiftlint.ymlandredundantTypein.swiftformatto prevent automatic removal of explicit type annotations.wrapMultilineStatementBracesin.swiftformatto prevent conflicts with SwiftLint'sopening_bracerule on multiline declarations..swiftlint.ymlwarnings by removing invalidanyobject_protocoland movingexplicit_self,unused_declaration, andunused_importunderanalyzer_rules.Codebase Lint Fixes (
Sources/FirebladeMath/):static_operator(43): Converted free operator declarations inMatrix+Operators.swiftandQuaternion+Operators.swifttostatic funcoverloads within type extensions.identifier_name(21): Expanded single-letter parameter and local variable names (e,q,a,b,c,m) to descriptive identifiers inQuat4f+Euler.swift,determinant.swift, andadjugate.swift.attributes(19): Standardized@inlinable,@usableFromInline, and@inline(__always)positioning across matrix/quaternion types and properties.opening_brace(6): Fixed opening brace positioning inMatrixStorage+SIMD.swift.multiline_arguments(6): Formatted multiline arguments consistently inmatrix.swift.computed_accessors_order(4): ReorderedgetbeforesetinQuaternionStorage+NO_SIMD.swift.function_parameter_count(4): Suppressed parameter count warning for orthographic projection methods inMatrix4x4+Projections.swiftwhile preserving public API signatures.blanket_disable_command(3): Replaced blanket disables withdisable:next/disable:this.identical_operands(2): Updatedsign.swiftto useisNaN.let_var_whitespace(1): Added blank line inQuat.swift.todo(1): Clarified comment inMatrixStorage+NO_SIMD.swift.file_length(1): Suppressed file length warning inMatrix+Multiplication.swift.Reviewer Guidance
Risk of Regression (RoR)
Low. All changes are purely code style, attribute layout, variable renaming, and operator scoping improvements. Public APIs, function signatures, and mathematical calculations are strictly preserved.
Testing & Verification
make lint(swiftlint+swiftformat) -> 0 errors / 0 violations.swift test-> 258/258 tests pass across 21 test suites../Scripts/profile-compiler-stats.sh-> Build frontend wall time improved (~22.3s vs ~24.9s baseline).