Repository navigation
Invalidate the hovered sample when the thread changes - #6374
Open
GBra-4-669 wants to merge 1 commit into
Open
GBra-4-669 wants to merge 1 commit into
GBra-4-669 wants to merge 1 commit into
Conversation
fatadel
self-requested a review
October 26, 2026 17:05
fatadel
requested changes
Oct 26, 2026
fatadel
left a comment
fatadel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution, @GBra-4-669! One thing that I've immediately noticed is the excessive amount of comments in the code. The code by itself should be readable and understandable, there is really no need to comment every line/block. We try to keep only absolutely necessary comments, that for example explain some non-obvious behavior.
Could you please redo your code, given this input?
Also, it would be nice if you could shrink the PR description and the commit message too. There is no need to explain implementation details. It should be a concise WHAT with a bit more elaborate WHY. Remember, those parts are meant to be read primarily by humans, not the AI.
The hovered sample belongs to the thread that was shown when the mouse last moved. Changing the committed range can leave the tooltip pointing at a sample index that's no longer valid or at the wrong sample. The hover is now cleared when the thread changes. Fixes firefox-devtools#5690
GBra-4-669
force-pushed
the
invalidate-hovered-sample
branch
from
October 26, 2026 18:09
24a10ee to
62f79ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Fixes #5690.
The hovered sample belongs to the thread that was shown when the mouse last
moved. Changing the committed range can leave the tooltip pointing at a sample
index that's no longer valid or at the wrong sample. The hover is now cleared
when the thread changes.