Skip to content

Keep requested reviewers for pull requests that have no reviews yet - #87

Open
porkedchop wants to merge 1 commit into
fivetran:mainfrom
porkedchop:fix/requested-reviewers-without-reviews
Open

porkedchop wants to merge 1 commit into
fivetran:mainfrom
porkedchop:fix/requested-reviewers-without-reviews

Conversation

@porkedchop

Copy link
Copy Markdown

Resolves #86

Please provide your name and company

Bishop Kammeraad

Describe what this PR changes and how it addresses the linked issue or feature request.

In int_github__pull_request_reviewers, the joined CTE now takes source_relation and pull_request_id from either side of the full outer join when github__using_requested_reviewer_history is enabled. Before, they came only from actual_reviewers, so a pull request with requested reviewers and no reviews got a null pull_request_id and its requested_reviewers never reached github__pull_requests.

How did you validate the changes introduced within this PR, and what warehouse did you use for testing?

DuckDB with the integration test seeds, no added rows. Before: 34 of 167 rows in github__pull_requests have requested_reviewers, and the 5 pull requests with a review request but no reviews (pull_request_id 408105961, 407401898, 516351583, 521867065, 442423917) are null. After: 39 of 167 and those 5 show the requested user. Comparing requested_reviewers, reviewers and number_of_reviews against main, those 5 are the only rows that change. Row count and issue_id uniqueness are unchanged. dbt build passes with github__using_requested_reviewer_history on and off.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] requested_reviewers is null for pull requests that have no reviews yet

1 participant