Repository navigation
Keep requested reviewers for pull requests that have no reviews yet - #87
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #86
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
In
int_github__pull_request_reviewers, thejoinedCTE now takessource_relationandpull_request_idfrom either side of the full outer join whengithub__using_requested_reviewer_historyis enabled. Before, they came only fromactual_reviewers, so a pull request with requested reviewers and no reviews got a nullpull_request_idand itsrequested_reviewersnever reachedgithub__pull_requests.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB with the integration test seeds, no added rows. Before: 34 of 167 rows in
github__pull_requestshaverequested_reviewers, and the 5 pull requests with a review request but no reviews (pull_request_id408105961, 407401898, 516351583, 521867065, 442423917) are null. After: 39 of 167 and those 5 show the requested user. Comparingrequested_reviewers,reviewersandnumber_of_reviewsagainst main, those 5 are the only rows that change. Row count andissue_iduniqueness are unchanged.dbt buildpasses withgithub__using_requested_reviewer_historyon and off.