Support portable measurement policies on bare metal - #83
Open
ameba23 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following Easy-TEE/attest#22 we want to allow portable measurement policies on bare metal.
Previously the
attestationcrate had a guard to disallow them as it was not fully implemented.This PR updates the attest crates and removes that guard. It also makes a change to the measurement policy record structure, as it must now explicitly specify an attestation type to remove ambiguity, as we can no longer assume portable measurements = GcpTdx.
Note for security: Unlike on GCP, we currently have no way to lookup the MRTD value to firmware on bare metal. So currently on bare metal, this will only match RTMR1 and 2, and accept any value for MRTD and RTMR0. So if the firmware is known, it is safer to use a 'standard' measurement policy and give the known MRTD value. If i understand correctly, Easy-TEE/attest#23 will address this.