Skip to content

docs(v2): Redis prefix for session keys - #418

Open
ivanzolotuhin wants to merge 2 commits into
flipt-io:mainfrom
ivanzolotuhin:authentication-redis-cache-prefix
Open

docs(v2): Redis prefix for session keys#418
ivanzolotuhin wants to merge 2 commits into
flipt-io:mainfrom
ivanzolotuhin:authentication-redis-cache-prefix

Conversation

@ivanzolotuhin

@ivanzolotuhin ivanzolotuhin commented Aug 14, 2026

Copy link
Copy Markdown

Adds the prefix field to the Redis session storage schema

Verified from Flipt's v2 branch source (internal/config/authentication.go):

type AuthenticationSessionStorageRedisConfig struct {
    ...
    Prefix string `json:"prefix" mapstructure:"prefix" yaml:"prefix"`
    Mode   RedisCacheMode `json:"mode" mapstructure:"mode" yaml:"mode"`
}   

@ivanzolotuhin
ivanzolotuhin requested a review from a team as a code owner August 14, 2026 09:18

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: comment

The PR adds a prefix row to the Redis session storage config table in overview.mdx, which addresses the prior review's request to keep the reference table consistent with the authentication examples. One issue: the default column is empty even though the PR description states the default is auth:... — the default should be filled in so users know the out-of-box behavior, consistent with how cache.redis.prefix documents its default of "flipt".

docs/v2/configuration/overview.mdx

  • minor (L324): The default column is empty for the authentication.session.storage.redis.prefix row, but the PR description states the default is auth:.... Fill in the default value in the table (e.g., auth:) so users know the default behavior without reading the example — consistent with how cache.redis.prefix documents its default of "flipt". If there is genuinely no default (empty string), clarify the PR description which currently claims a default exists.

🤖 Automated review by the Flipt PR review agent.

@ivanzolotuhin ivanzolotuhin left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to schema

@ivanzolotuhin ivanzolotuhin changed the title Redis prefix for session keys docs(v2): Redis prefix for session keys Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant