docs(v2): Redis prefix for session keys - #418
Open
ivanzolotuhin wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Verdict: comment
The PR adds a prefix row to the Redis session storage config table in overview.mdx, which addresses the prior review's request to keep the reference table consistent with the authentication examples. One issue: the default column is empty even though the PR description states the default is auth:... — the default should be filled in so users know the out-of-box behavior, consistent with how cache.redis.prefix documents its default of "flipt".
docs/v2/configuration/overview.mdx
- minor (L324): The default column is empty for the
authentication.session.storage.redis.prefixrow, but the PR description states the default isauth:.... Fill in the default value in the table (e.g.,auth:) so users know the default behavior without reading the example — consistent with howcache.redis.prefixdocuments its default of"flipt". If there is genuinely no default (empty string), clarify the PR description which currently claims a default exists.
🤖 Automated review by the Flipt PR review agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the prefix field to the Redis session storage schema
Verified from Flipt's v2 branch source (
internal/config/authentication.go):