fix(flow-php/symfony-telemetry-bundle): twig span lifecycle#2458
Open
norberttech wants to merge 2 commits into
Open
fix(flow-php/symfony-telemetry-bundle): twig span lifecycle#2458norberttech wants to merge 2 commits into
norberttech wants to merge 2 commits into
Conversation
- mark successful twig spans as OK - complete spans orphaned by a render exception as error via reset() on terminate/kernel.reset
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2458 +/- ##
==========================================
- Coverage 85.13% 85.12% -0.01%
==========================================
Files 1598 1599 +1
Lines 65485 65511 +26
==========================================
+ Hits 55748 55768 +20
- Misses 9737 9743 +6 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/symfony-telemetry-bundle- cleanup subscriber completing Twig spans orphaned by a render exception on terminate/kernel.resetFixed
flow-php/symfony-telemetry-bundle- successful Twig spans now report OK statusChanged
Removed
Deprecated
Security