Skip to content

176989 ucr flag removal - #5146

Open
ievdokdm wants to merge 11 commits into
flutter:mainfrom
ievdokdm:176989-ucr-flag-removal
Open

176989 ucr flag removal#5146
ievdokdm wants to merge 11 commits into
flutter:mainfrom
ievdokdm:176989-ucr-flag-removal

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

fix: flutter/flutter#176989
reverted config change

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 8, 2026
@ievdokdm
ievdokdm requested review from eyebrowsoffire and jtmcdole and removed request for jtmcdole September 8, 2026 23:57
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Sep 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy GitHub check run flow, making the Unified Check Run flow the default and only flow. It cleans up related feature flags, fields (such as isUnifiedCheckRun), and conditional logic across the Scheduler, LuciBuildService, and PresubmitSubscription classes. Additionally, it updates the device_doctor package to use platform.nativePlatform!.environment instead of platform.environment, and improves error handling in the fake Firestore service to return a conflict status code (409) when a transaction is aborted. There are no review comments to address, and I have no additional feedback to provide.

@ievdokdm ievdokdm removed the autosubmit Merge PR when tree becomes green via auto submit App. label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove legacy check-run flow and configuration

1 participant