176989 ucr flag removal - #5146
Open
ievdokdm wants to merge 11 commits into
Open
Conversation
Co-authored-by: Jackson Gardner <eyebrowsoffire@gmail.com>
ievdokdm
requested review from
eyebrowsoffire and
jtmcdole
and removed request for
jtmcdole
September 8, 2026 23:57
There was a problem hiding this comment.
Code Review
This pull request removes the legacy GitHub check run flow, making the Unified Check Run flow the default and only flow. It cleans up related feature flags, fields (such as isUnifiedCheckRun), and conditional logic across the Scheduler, LuciBuildService, and PresubmitSubscription classes. Additionally, it updates the device_doctor package to use platform.nativePlatform!.environment instead of platform.environment, and improves error handling in the fake Firestore service to return a conflict status code (409) when a transaction is aborted. There are no review comments to address, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: flutter/flutter#176989
reverted config change