Skip to content

setup.sh: tidy some shell-fu in order to detect 'flutter' and resolve 'dart' better #10059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srawlins merged 2 commits into from
Oct 30, 2026
+17 −15
Merged

setup.sh: tidy some shell-fu in order to detect 'flutter' and resolve 'dart' better #10059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0934cb3
setup.sh: tidy some shell-fu in order to detect flutter and resolve d…
srawlins Oct 30, 2026
23ca2e0
Update tool/ci/setup.sh
srawlins Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions tool/ci/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,16 @@ set -ex
export SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
export DEVTOOLS_DIR=$SCRIPT_DIR/../..

# In GitBash on Windows, we have to call flutter.bat so we alias them in this
# script to call the correct one based on the OS.
function flutter {
if [[ $RUNNER_OS == "Windows" ]]; then
command flutter.bat "$@"
else
command flutter "$@"
fi
}
export -f flutter

# Determine the Flutter SDK to use:
# * If `DEVTOOLS_TOOL_FLUTTER_FROM_PATH` is "true", then discover from `PATH`.
# * If `./tool/flutter-sdk` (a directory) exists, then use that.
if [ "$DEVTOOLS_TOOL_FLUTTER_FROM_PATH" = "true" ]; then
if command -v flutter &> /dev/null; then
FLUTTER_EXE="$(command -v flutter)"
elif command -v flutter.bat &> /dev/null; then
FLUTTER_EXE="$(command -v flutter.bat)"
# Use `type -P` instead of `command -v` so we resolve an executable file on
# PATH rather than a shell function or alias.
if type -P flutter &> /dev/null; then
FLUTTER_EXE="$(type -P flutter)"
elif type -P flutter.bat &> /dev/null; then
FLUTTER_EXE="$(type -P flutter.bat)"
else
echo "DEVTOOLS_TOOL_FLUTTER_FROM_PATH is set to true, but flutter was not found on PATH"
exit 1
Expand All @@ -50,6 +41,17 @@ fi
# inopportune times.
export PATH="$FLUTTER_DIR/bin/cache/dart-sdk/bin:$FLUTTER_DIR/bin:`pwd`/bin:$PATH"

# In GitBash on Windows, we have to call flutter.bat so we alias them in this
# script to call the correct one based on the OS.
function flutter {
if [[ "$RUNNER_OS" == "Windows" || "$OSTYPE" == "msys" || "$OSTYPE" == "cygwin" ]]; then
command flutter.bat "$@"
else
command flutter "$@"
fi
}
Comment thread
srawlins marked this conversation as resolved.
Resolved
export -f flutter

# Look up the latest flutter candidate (this is the latest flutter version in g3)
# TODO(https://github.com/flutter/devtools/issues/4591): re-write this script as a
# shell script so we won't have to incurr the cost of building flutter tool twice.
Expand Down
Loading