Make sure that extensions are bundled with the package they claim to be. - #9981
Merged
Merged
Conversation
With this change, extensions are enabled if and only if the package name on disk matches the package name in extension/devtools/config.yaml.
johnpryan
requested review from
a team,
bkonyi and
kenzieschmoll
as code owners
August 26, 2026 21:40
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves DevTools extension isolation by tracking the providing package name for enablement, deduplication, and asset loading, and adds validation checks for extension names. The review feedback highlights a compilation error in _extensions_api.dart due to invalid map literal syntax, a potential runtime TypeError in _validate.dart when casting the configuration name, and a suggestion to normalize packageRoot in extension_manager.dart for more robust path comparisons.
Contributor
Author
|
@kenzieschmoll this is ready for another look |
Make extensionPackage a required non-nullable parameter in extensionEnabledState Make packageName non-nullable parameter in TestPackageWithExtension
Contributor
Author
|
@kenzieschmoll this should be ready for another review |
kenzieschmoll
approved these changes
Sep 15, 2026
Member
|
Please address all unresolved comments before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, extensions are enabled if and only if the package name on disk matches the package name in extension/devtools/config.yaml.
This supersedes #9965