[google_fonts] Decouple GoogleFontsLite for full tree-shaking and add full feature parity - #12830
Open
Piinks wants to merge 5 commits into
Open
[google_fonts] Decouple GoogleFontsLite for full tree-shaking and add full feature parity#12830Piinks wants to merge 5 commits into
Piinks wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request decouples the internal base library from the main entry point to ensure complete tree-shakability, and adds config, pendingFonts, and getTextTheme to GoogleFontsLite along with documentation and tests. The review feedback suggests throwing an ArgumentError instead of a generic Exception when a font family is not found in getTextTheme, and updating the corresponding test to match.
Piinks
force-pushed
the
google-fonts-lite-enhancements
branch
from
September 10, 2026 22:38
4aa7b60 to
3a212e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #11433 #11433, google_fonts_lite.dart was introduced as an alternative entry point containing only dynamic font resolution methods and the family descriptor map, allowing compilers to tree-shake the static generated font methods.
#11433 was a huge PR, and a breaking one, so we did not publish it yet. Currently this package is set to publish_to: none.
For these reasons I decided to follow up on a few more bits of polish here instead of belaboring the mega PR and the contributor's effort.
After this change, I will migrate this package to material_ui and then we will publish one major release with all of these changes to reduce churn on the ecosystem.
This PR ensures google_fonts_lite.dart is fully decoupled from the main entry point by sharing an internal configuration singleton, ensuring complete compiler tree-shaking of unused generated font code, while adding missing features to google fonts lite for full feature parity with the non-lite version.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2