-
Notifications
You must be signed in to change notification settings - Fork 4k
[material_ui] Add Material 3 Expressive IconButton #12832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,115
−21
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
81482e7
Add M3E IconButton
QuncCccccc bd6ac5b
Rename IconButton M3E template
QuncCccccc b58d013
Add IconButton xSmall tap target coverage
QuncCccccc ad3c453
Rename IconButton M3E style variants
QuncCccccc e0f40a0
Rename M3E IconButton default internals
QuncCccccc 310555b
Use padded tap target for M3E IconButton defaults
QuncCccccc f4b6db1
Document M3E IconButton tap target defaults
QuncCccccc 9aec3af
Expand ButtonStyle variant documentation
QuncCccccc 9a7f441
Clarify ButtonStyle variant enum docs
QuncCccccc 1d07dcd
Move IconButton variant defaults to IconButton docs
QuncCccccc a592aa8
Refine ButtonSize API documentation
QuncCccccc 6a60a93
Rephrase ButtonStyle size variant docs
QuncCccccc 7076f83
Simplify ButtonStyle size variant docs
QuncCccccc 42e7a80
Clarify IconButton width variant docs
QuncCccccc 885832a
Clarify ButtonStyle shape variant docs
QuncCccccc 4e7b7c1
Polish IconButton variant style docs
QuncCccccc 2822adc
Clarify IconButton M3E option docs
QuncCccccc e877ff8
Simplify IconButton M3E option docs
QuncCccccc 39f1cc6
Separate IconButton M3E default docs
QuncCccccc 8595f5a
Inline IconButton variant style lookup
QuncCccccc 4d9f13d
Clean up IconButton M3E default variants
QuncCccccc 05e63bb
Move IconButton M3E variant getters
QuncCccccc b9567d9
Clarify IconButton M3E default constructors
QuncCccccc 701ac2f
Rename IconButton M3E variant enums
QuncCccccc 7128649
Clarify IconButton M3 defaults docs
QuncCccccc 30150ea
Move IconButton useMaterial3 TODO
QuncCccccc e5471d3
Simplify IconButton variant docs
QuncCccccc 99177d2
Clean up IconButton M3E tests
QuncCccccc 0509c4b
Apply M3E test theme defaults
QuncCccccc 07e81d1
Simplify IconButton M3E test helper
QuncCccccc 6e002ef
Add IconButton M3E release info
QuncCccccc 3ced364
Address Gemini comment
QuncCccccc 00046d2
Split IconButton M3E generated defaults
QuncCccccc 7a30d30
Fix IconButton template lint after rebase
QuncCccccc e5b7688
Address feedback
QuncCccccc 0889ca3
Reformat to fix Linux repo checks
QuncCccccc 9186a12
Replace deprecated withOpacity with withValues
QuncCccccc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these new properties get added to the
button_style_test?Also should these be
WidgetStateProperties? Ooc, what doesWidgetStatePropertymean and how do we decide which properties areWidgetStateProperties?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
WidgetStatePropertyrepresents a value that can resolve differently depending on states such as pressed, hovered, focused, disabled, or selected.For example, components' overlayColor will change a little bit based on different states, so we will have something like
The new properties do not change by widget state. They select a button configuration. For example,
ButtonSizeVariant.smallselects a coordinated set of values for properties such asButtonStyle.iconSize,ButtonStyle.padding,ButtonStyle.minimumSize, andButtonStyle.shape. Those resulting properties areWidgetStatePropertys where state-dependent resolution is needed. Let me know if this doesn't make sense:)!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests!