[material_ui] Migrate M3 Chip template to use new gen_defaults - #12847
Open
QuncCccccc wants to merge 1 commit into
Open
[material_ui] Migrate M3 Chip template to use new gen_defaults#12847QuncCccccc wants to merge 1 commit into
QuncCccccc wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Material 3 Chip defaults generator to use the new TokenTemplateM3 template and token database. Specifically, it moves the generated _ChipDefaultsM3 class from chip.dart into a separate generated part file chip_defaults_m3.g.dart, updates ChipTemplateM3 to reference structured TokenFilterChip properties instead of string-based token paths, and implements the corresponding unit tests in gen_defaults_test.dart. There are no review comments, so no additional feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#187899
Fixes flutter/flutter#188408
Migrates the M3 Chip defaults template to the new
packages/material_ui/tool/gen_defaultsgenerator.Pre-Review Checklist
[shared_preferences]///).