[material_ui] Migrate M3 FilterChip template to use new gen_defaults - #12849
Draft
QuncCccccc wants to merge 1 commit into
Draft
[material_ui] Migrate M3 FilterChip template to use new gen_defaults#12849QuncCccccc wants to merge 1 commit into
FilterChip template to use new gen_defaults#12849QuncCccccc wants to merge 1 commit into
Conversation
QuncCccccc
marked this pull request as draft
September 12, 2026 04:20
FilterChip template to use new gen_defaults
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the generation of Material 3 defaults for FilterChip to a token-based template system. It removes the inline _FilterChipDefaultsM3 class from filter_chip.dart and references it as a generated part file. It introduces FilterChipTemplateM3 to generate these defaults, enables the template in the generator script, and adds unit tests to verify the generated output. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899.
Fixes flutter/flutter#188416.
Depends on #12848. Will wait until #12848 lands first.
Migrates the M3
FilterChipdefaults template to the newpackages/material_ui/tool/gen_defaultsgenerator.Pre-Review Checklist
[shared_preferences]///).