Order arm64 builds first in SDK archive - #13713
Open
parlough wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release fetching logic in archive_table.dart to group releases by version and sort them by architecture. The review feedback correctly points out that relying on alphabetical sorting to place 'arm64' first is fragile, and suggests using a priority-based sorting approach instead to ensure robustness.
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit 27a5331): https://flutter-docs-prod--docs-pr13713-misc-order-arm64-first-3ovtrcs6.web.app |
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit 27a5331): https://flutter-dev-230821--www-pr13713-misc-order-arm64-first-ibq0jygu.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the SDK archive, order arm64 builds before x64 builds within each release. This only affects macOS currently and helps promote arm64 builds over x64 builds on the road to their deprecation.
Staged: https://flutter-docs-prod--docs-pr13713-misc-order-arm64-first-3ovtrcs6.web.app/install/archive#stable-channel