Repository navigation
Remove unsupported directory syntax from pubspec shaders section - #13974
Merged
Merged
Conversation
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit ece52d3): https://flutter-docs-prod--docs-pr13974-pubspec-shaders-files-m2cueur6.web.app |
jesskuras
marked this pull request as ready for review
October 12, 2026 18:09
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the shaders field in pubspec.yaml to clarify that only individual file paths are supported and that shaders should not be listed under the assets field. The review feedback correctly points out that shaders only support flavors and do not support platforms or transformers, suggesting a correction to the text.
parlough
approved these changes
Oct 13, 2026
parlough
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this and the nearby clean up. Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Updates the
shadersfield section on the Flutter pubspec options page (/tools/pubspec#shaders):path_to_directorysyntax and directory example, clarifying that each.fragshader file must be listed individually (sinceflutter_toolsonly parses individual file paths underflutter.shaders).assetsfield (sinceflutter_toolsrequires.fragshaders to be declared undershadersto compile them withimpellerc).platformsalongsideflavorsandtransformers, and links to the Writing and using fragment shaders guide.Issues fixed by this PR (if any):
Fixes #13972
PRs or commits this PR depends on (if any):
None
Presubmit checklist
of 80 characters or fewer.