Repository navigation
fix(device_info_plus): handle single-quoted values in os-release on Linux - #4012
Open
ChandraChaan wants to merge 1 commit into
Open
ChandraChaan wants to merge 1 commit into
ChandraChaan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Linux implementation reads
/etc/os-releaseand strips quotes from each value, but only double quotes. The os-release format allows values in single quotes too, and Gentoo now writes its file that way (NAME='Gentoo',ID='gentoo', ...). So on GentoolinuxInfo.idis'gentoo'with the quotes included, and checks likeid == 'gentoo'fail.unquote()now strips single quotes when the value starts with one, and otherwise behaves as before. Double-quoted and unquoted values are unchanged.Added a test that uses Gentoo's actual
os-releasecontents.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change