fix: only one incoming value added when exchanging an empty repeatable field - #450
Merged
Merged
Conversation
… field With the "Delete all existing and add these" action (EXCHANGE_EXISTING) and an initially empty array, alreadyRemovedForExchange was never set on the first iteration, so the second incoming value deleted the first one. Set the flag on the first iteration regardless of whether anything was removed. Update the test that asserted the old behavior and add a regression test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
psmagin
changed the title
|
viacheslavkol
approved these changes
Oct 2, 2026
viacheslavkol
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix only one incoming value added when exchanging an empty repeatable field
Approach
With the "Delete all existing and add these" action (EXCHANGE_EXISTING) and an
initially empty array, alreadyRemovedForExchange was never set on the first
iteration, so the second incoming value deleted the first one. Set the flag on
the first iteration regardless of whether anything was removed.
Update the test that asserted the old behavior and add a regression test.
Changes Checklist
Related Issues
https://folio-org.atlassian.net/browse/MODDICORE-516