[MODEXPS-315] Export Configuration create/update domain events - #383
Merged
Conversation
Contributor
|
Please fix the Sonar issues. |
SerhiiNosko
reviewed
Aug 4, 2026
SerhiiNosko
reviewed
Aug 4, 2026
SerhiiNosko
reviewed
Aug 4, 2026
…tial handling and implement event redaction
…entials before publishing events and remove dtos
|
SerhiiNosko
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
[MODEXPS-315] Export Configuration create/update domain events
Approach
Evaluation
Create Event for Export Configuration
Full payload:
{ "eventId": "ed4b0d6f-57f0-4162-b3c9-6dca4028c006", "eventTs": 1786003184969, "tenant": "diku", "type": "CREATE", "new": { "id": "dfa97898-a7fc-4f82-8673-85f66e65efcf", "type": "CLAIMS", "configName": "CLAIMS_e0fb5df2-cdf1-11e8-a8d5-f2801f1b9fd1_dfa97898-a7fc-4f82-8673-85f66e65efcf", "tenant": "diku", "exportTypeSpecificParameters": { "vendorEdiOrdersExportConfig": { "exportConfigId": "dfa97898-a7fc-4f82-8673-85f66e65efcf", "vendorId": "e0fb5df2-cdf1-11e8-a8d5-f2801f1b9fd1", "configName": "Test", "ediConfig": { "ediNamingConvention": "{organizationCode}-{integrationName}-{exportJobEndDate}", "libEdiType": "31B/US-SAN", "vendorEdiType": "31B/US-SAN", "sendAccountNumber": false, "supportOrder": false, "supportInvoice": false }, "ediFtp": { "ftpConnMode": "Active", "ftpFormat": "SFTP", "ftpMode": "ASCII", "username": "test" }, "isDefaultConfig": false, "integrationType": "Claiming", "transmissionMethod": "File download", "fileFormat": "CSV" } }, "schedulePeriod": "NONE" } }The
ediFtppassword is missing from the event payload, even though it was entered in the UI as required by the story.Update Event for Export Configuration
Full payload (including
configNameandnotesdifference):{ "eventId": "b1fd6979-c63d-4958-8b2f-7ac6825f53af", "eventTs": 1786003363622, "tenant": "diku", "type": "UPDATE", "old": { "id": "dfa97898-a7fc-4f82-8673-85f66e65efcf", "type": "CLAIMS", "configName": "CLAIMS_e0fb5df2-cdf1-11e8-a8d5-f2801f1b9fd1_dfa97898-a7fc-4f82-8673-85f66e65efcf", "tenant": "diku", "exportTypeSpecificParameters": { "vendorEdiOrdersExportConfig": { "exportConfigId": "dfa97898-a7fc-4f82-8673-85f66e65efcf", "vendorId": "e0fb5df2-cdf1-11e8-a8d5-f2801f1b9fd1", "configName": "Test", "ediConfig": { "ediNamingConvention": "{organizationCode}-{integrationName}-{exportJobEndDate}", "libEdiType": "31B/US-SAN", "vendorEdiType": "31B/US-SAN", "sendAccountNumber": false, "supportOrder": false, "supportInvoice": false }, "ediFtp": { "ftpConnMode": "Active", "ftpFormat": "SFTP", "ftpMode": "ASCII", "username": "test" }, "isDefaultConfig": false, "integrationType": "Claiming", "transmissionMethod": "File download", "fileFormat": "CSV" } }, "schedulePeriod": "NONE" }, "new": { "id": "dfa97898-a7fc-4f82-8673-85f66e65efcf", "type": "CLAIMS", "configName": "CLAIMS_e0fb5df2-cdf1-11e8-a8d5-f2801f1b9fd1_dfa97898-a7fc-4f82-8673-85f66e65efcf", "tenant": "diku", "exportTypeSpecificParameters": { "vendorEdiOrdersExportConfig": { "exportConfigId": "dfa97898-a7fc-4f82-8673-85f66e65efcf", "vendorId": "e0fb5df2-cdf1-11e8-a8d5-f2801f1b9fd1", "configName": "Test NEW", "ediConfig": { "ediNamingConvention": "{organizationCode}-{integrationName}-{exportJobEndDate}", "libEdiType": "31B/US-SAN", "vendorEdiType": "31B/US-SAN", "notes": "TEST NOTE", "sendAccountNumber": false, "supportOrder": false, "supportInvoice": false }, "ediFtp": { "ftpConnMode": "Active", "ftpFormat": "SFTP", "ftpMode": "ASCII", "username": "test" }, "isDefaultConfig": false, "integrationType": "Claiming", "transmissionMethod": "File download", "fileFormat": "CSV" } }, "schedulePeriod": "NONE" } }Expected:
Include the differences between the old and new payloads, including updates to
configNameandnotes.Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.