MODEXPW-638 - Add custom-fields read permission for the order email export - #384
Open
markusweigelt wants to merge 1 commit into
Open
MODEXPW-638 - Add custom-fields read permission for the order email export#384markusweigelt wants to merge 1 commit into
markusweigelt wants to merge 1 commit into
Conversation
Grant the system user orders-storage.custom-fields.collection.get so PO and PO line custom field values can be fetched for the order email export, and update folio-export-common to the schemas exposing customFields.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODEXPW-638 - Add custom-fields read permission for the order email export
Purpose
The EDIFACT/CSV order email export renders PO and PO-line custom fields as template tokens (
order.customFields.<refId>/orderLine.customFields.<refId>). The values ride along with the records the export already fetches, but the definitions — field names and select-option labels — have to be read from mod-orders-storage'sGET /custom-fields, and that call is madeby mod-data-export-worker under the data-export system user.
Approach
orders-storage.custom-fields.collection.gettosrc/main/resources/permissions/system-user-permissions.csv, alongside the existingorders-storage.*reads the orders export already relies on.descriptors/ModuleDescriptor-template.jsonin all four places the same orders-storage read set is listed:modulePermissionsofPOST /data-export-spring/jobsmodulePermissionsofPOST /data-export-spring/jobs/sendsubPermissionsofdata-export.edifact.orders.createmetadata.user.permissionssystem-user setfolio-export-commonsubmodule to pick up thecustomFieldsmap on thepurchase_order,composite_purchase_orderandpo_lineschemas.