Repository navigation
Docs: a service account's name stays local only while the local realm comes first - #706
Merged
Merged
Conversation
The deployment guide said a service account's name is never forwarded to a credential-forwarding upstream. The realms are asked in priority order and the forwarding provider asks its upstream before any account lookup, so with a forwarding realm ahead of `local`, or `local` disabled, a login or Basic attempt as a service account sends its local part and the typed password upstream (and is still refused). The guide now qualifies the claim, for service accounts and for invited users, which it made too. Fixes #551 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012e6DJXRhLYxFjzrWiwKFKc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551
docs/deployment.md(Service accounts) said a service account's name is never forwarded to a credential-forwarding upstream. That holds only while thelocalrealm is enabled and comes before every credential-forwarding realm:crates/server/src/auth/realms.rs);localends a password attempt as a service account itself:LocalPasswordProviderrejects it after a dummy verification, a terminal answer;crates/core/src/auth/upstream_basic.rs).So with a forwarding realm moved ahead of
local, orlocaldisabled, a login or Basic attempt asci@example.comsendsciand the typed password upstream. The attempt is still refused, becausemap_identity_to_principalmaps an upstream verdict only onto anupstream-basicaccount of that realm.Changes
I took the issue's first option and qualified the docs. The other option, having the forwarding provider look up the name before forwarding, adds an account lookup to every forwarded attempt, and the issue is filed as documentation.
local, and what happens with a forwarding realm ahead of it orlocaldisabled: the name goes upstream and the attempt is still refused. Local and invited accounts behave the same.docs/changes/2.2.0/551.docs.md.Checks run
cargo xtask changelog --check,cargo xtask docs --check(the new anchor link resolves).Generated by Claude Code