ui: Include tip for DEVICE_API endpoint - #232
Merged
Merged
Conversation
fio-device-register needs the user to set `--device-api`. This isn't totally obvious for a user. Showing this value in the settings is a way to cheat and likely get the user's attention: they'll need to go to the place to generate their API token and will probably see it. Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
Member
Author
|
Member
Author
|
@mike-scott - a bit of a usability question. I hit this very problem today and was trying to think of a way to better expose this information when we are no longer able to provide defaults for it in our LmP |
|
@doanac ah, this fills a nice gap. |
|
Question: Not sure if this can work right through a container (like it might show the internal port that it knows about, but not the mapped port externally) |
Member
Author
It works in a container as well. We've used this pattern a couple places in the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fio-device-register needs the user to set
--device-api. This isn't totally obvious for a user. Showing this value in the settings is a way to cheat and likely get the user's attention: they'll need to go to the place to generate their API token and will probably see it.