Conversation
fox0430
force-pushed
the
ci/enable-macos-test-matrix
branch
from
June 23, 2026 10:52
2940538 to
50ee588
Compare
# Conflicts: # tests/all_tests.nim
# Conflicts: # .github/workflows/test.yml
…matrix # Conflicts: # tests/all_tests.nim
# Conflicts: # tests/all_tests.nim
Resolve conflicts in async_postgres.nimble and tests/all_tests.nim: keep the unit/integration test split from this branch and take the apiSurface tasks from main. Also add test_aggregate, test_copy_race and test_tls_error_paths to all_tests_unit.nim. The split was based on an older import list, so these mock-server/compile-time tests ended up in neither aggregate file.
`wait()`'s default orphan hook clears a late failure on the inner future. `drainAbandonedAcquire` awaits that same future, so once the error is gone its `read()` returns a nil connection instead of raising, and the drain dereferences nil in `releaseReclaimed`. Pass a no-op orphan hook at both cluster `wait()` sites (the drain owns the outcome) and guard the drain against a nil connection.
# Conflicts: # tests/all_tests.nim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.