feat: add seed via exception context - #113
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
pbrisbin
marked this pull request as ready for review
August 3, 2026 19:41
cdmren
reviewed
Aug 3, 2026
cdmren
reviewed
Aug 3, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
cdmren
requested changes
Aug 10, 2026
cdmren
approved these changes
Aug 17, 2026
pbrisbin
enabled auto-merge (rebase)
August 24, 2026 13:47
Member
Author
|
We need a third reviewer now because Chris is last pusher and it's my PR. |
This moves the `throwIO` out of the function that is concretely `HUnitFailure`. This is because I'll next be adding something that needs to occur between those two points.
When using `base > 4.20` we add exception context that includes the graphula seed. Closes #44 as best we can. The information won't appear anywhere automatically, but can be pulled out (e.g.) via `SpecHook` for those that know (see README). This is a compromise. Given how `hspec` works today, any other method that would make the seed more visible for non-expectation-failure exceptions comes with too many negative trade-offs.
mjgpy3
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using
base >= 4.20, we now add the graphula seed as an annotation in the exception context12.This will be present for all exceptions (closes #44), but it's not readily visible anywhere. It must be extracted specifically via hooks (see the tests). Therefore, this hasn't replaced the textual-addition to
HUnitFailure, it is in addition to.Footnotes
https://hackage-content.haskell.org/package/base-4.22.0.0/docs/Control-Exception-Context.html ↩
https://well-typed.com/blog/2026/05/lay-annotation-land/ ↩