feat(modal): support OIDC-authenticated cloud bucket mounts - #6
Open
fscfede-beep wants to merge 9 commits into
Open
feat(modal): support OIDC-authenticated cloud bucket mounts#6fscfede-beep wants to merge 9 commits into
fscfede-beep wants to merge 9 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements openai#4705.
Modal's current
CloudBucketMountsupportsoidc_auth_role_arn, butModalCloudBucketMountStrategydid not expose or pass it through. This adds an optionaloidc_auth_role_arnto the strategy/config, rejects mixing OIDC with named secrets, passes the role ARN tomodal.CloudBucketMount, and adds manifest/config/creation regression coverage plus documentation.Existing inline-credential and named-secret behavior remains unchanged.
Validated against current Modal documentation, which exposes
CloudBucketMount(..., oidc_auth_role_arn=None, ...).