Fall back to full file content for local regex filtering - #154
Merged
shouze merged 2 commits intoAug 23, 2026
Merged
Conversation
shouze
changed the title
shouze
force-pushed
the
fix/regex-local-filter-full-content
branch
from
August 23, 2026 13:58
0a9020d to
a3953c8
Compare
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
Adds full-file fallback support for local regex filtering when GitHub fragments are insufficient.
Changes:
- Adds optional
CodeMatch.fileContent. - Propagates fetched raw content.
- Implements full-content fallback matching and context extraction.
- Adds regression and compatibility tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Review comments |
|---|---|
src/types.ts |
Adds optional raw-content support; no issues noted. |
src/api.ts |
Moderate: avoid retaining raw content for non-regex queries (3 votes). Nit: add API tests for propagation and failed fetches (4 votes). |
src/aggregate.ts |
Moderate: avoid repeated full-prefix rescans (3 votes). Moderate: preserve matches spanning beyond the display window (4 votes). |
src/aggregate.test.ts |
Adds fallback and compatibility coverage; no issues noted. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+170
to
+174
| updatedTextMatches = [...findMatchLines(fileContent, globalRe)] | ||
| .map((matchLine) => { | ||
| const { fragment, fragmentStartLine } = sliceContextWindow(fileContent, matchLine); | ||
| const segs = recomputeSegments(fragment, globalRe, fragmentStartLine); | ||
| return segs.length > 0 ? { fragment, matches: segs } : null; |
shouze
force-pushed
the
fix/regex-local-filter-full-content
branch
from
August 23, 2026 14:26
a3953c8 to
322e43c
Compare
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
aggregate() previously tested the local regex filter only against TextMatch.fragment, the truncated excerpt returned by the GitHub API. If that excerpt did not cover the full portion matched by the regex, the repository was silently dropped even though the actual file matched. fetchAllResults() already downloads the raw file content from raw.githubusercontent.com to resolve absolute line numbers; it now propagates that content into CodeMatch.fileContent (src/types.ts) instead of discarding it. aggregate() falls back to matching against fileContent, and builds a small context window around each match for display, only when none of the API-provided fragments matched. No new network calls, and behaviour is unchanged when fileContent is absent or when the fragment already matches. Closes #148
shouze
force-pushed
the
fix/regex-local-filter-full-content
branch
from
August 23, 2026 14:36
322e43c to
a818982
Compare
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
- aggregate.ts: replace the O(n*m) prefix-rescan findMatchLines/sliceContextWindow pair with fallbackMatchesFromFullContent, which finds every match in a single forward pass over the full file content and expands the display window to always contain the match's full span, so matches longer than the +/-2 line window (or reached via lookaround) are no longer silently dropped. - api.ts: fetchAllResults now only retains raw fileContent on CodeMatch when the new keepFileContent flag is set, avoiding keeping every downloaded file in memory for ordinary (non-regex) queries. - github-code-search.ts: pass keepFileContent=true only when a regex filter is active. - Add regression tests: aggregate.test.ts covers matches spanning beyond the context window and multiple distinct matches; api.test.ts covers the fileContent handoff from fetchAllResults (success, failure, opt-out). See #154 (comment) See #154 (comment) See #154 (comment) See #154 (comment)
|
Coverage after merging fix/regex-local-filter-full-content into fix/plain-text-quote-validation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #148.
aggregate()previously tested the local regex filter only againstTextMatch.fragment, the truncated excerpt returned by the GitHub API. If that excerpt did not cover the full portion matched by the regex, the repository was silently dropped even though the actual file matched.fetchAllResults()already downloads the raw file content from raw.githubusercontent.com to resolve absolute line numbers; it now propagates that content into the new optionalCodeMatch.fileContentfield (src/types.ts) instead of discarding it.aggregate()falls back to matching againstfileContent, and builds a small context window around each match for display, only when none of the API-provided fragments matched. No new network calls are introduced, and behaviour is unchanged whenfileContentis absent or when the fragment already matches.How did you verify your code works?
src/aggregate.test.tscovering the fallback path, the no-match case, the already-matching-fragment case (no behaviour change), and thefileContent-absent backward-compatibility case.