Make crosses on info banners visible in dark mode#4307
Open
Sseik wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request improves the visibility of the close x on InfoBanner components when the site is in dark mode, where the banner background remains light.
Changes:
- Updated the inline close button text color in four InfoBanner components to a fixed dark color value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/components/InfoBanner.js | Sets a fixed close button color to keep the x visible in dark mode. |
| src/components/InfoBanner2.js | Sets a fixed close button color to keep the x visible in dark mode. |
| src/components/InfoBanner3.js | Sets a fixed close button color to keep the x visible in dark mode. |
| src/components/InfoBanner4.js | Sets a fixed close button color to keep the x visible in dark mode. |
| backgroundColor: 'transparent', | ||
| border: 'none', | ||
| color: 'var(--color-text)', | ||
| color: '#33332D', |
| backgroundColor: 'transparent', | ||
| border: 'none', | ||
| color: 'var(--color-text)', | ||
| color: '#33332D', |
| backgroundColor: 'transparent', | ||
| border: 'none', | ||
| color: 'var(--color-text)', | ||
| color: '#33332D', |
| backgroundColor: 'transparent', | ||
| border: 'none', | ||
| color: 'var(--color-text)', | ||
| color: '#33332D', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crosses on info banners were turning white in the dark mode, which made them barely visible on the light background, so I changed the buttonStyle to always use the color it uses in the light mode. Also, I had to create an empty .cache directory in the root before I could start the app, you might want to add it to the CONTRIBUTING.md