feat: Add DecOptions.FixedArrayLength to enforce Go array length - #848
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Add FixedArrayLength decoding option to validate that CBOR byte string and array lengths strictly match destination Go fixed-size array dimensions. When FixedArrayLength is set to FixedArrayLengthEnforced, length mismatches return an *UnmarshalTypeError instead of zero-padding shorter inputs or silently truncating longer inputs. Default decoding behavior continues to match Go standard library encoding/json codec. Fixes fxamacker#735 Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
Owner
Thanks, I'll take a look after wrapping up in-progress work needed to release v2.9.5 and v2.10.0. In the meantime, user-defined types implementing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When decoding CBOR byte strings or arrays into Go fixed-size arrays ([N]byte or [N]T), the default decoder behavior follows Go standard library encoding/json semantics: shorter inputs are padded with zero values and longer inputs are truncated.
This PR introduces a FixedArrayLength decoding option (FixedArrayLengthMode / alias ArrayLengthMode) with two settings:
Fixes #735
PR Was Proposed and Welcomed in Currently Open Issue
Checklist (for code PR only, ignore for docs PR)
Last line of each commit message should be in this format:
Signed-off-by: Firstname Lastname firstname.lastname@example.com
(see next section).
Certify the Developer's Certificate of Origin 1.1
the Developer Certificate of Origin 1.1.