fix(hugo): gate Hugo-specific transforms behind --hugo flag - #497
Merged
Merged
Conversation
Three places in the pipeline ran Hugo-specific logic regardless of the --hugo flag: _index.md rename in FSWriter, HugoStructuralDirs trimming in buildOutputLink, and ReAnchorRootAbsolute in resolveRelativeToAbsolute. All three are now guarded by Hugo.Enabled / f.Hugo.
gardener-prow
Bot
added
the
do-not-merge/needs-kind
gardener-prow
Bot
added
the
size/M
|
LGTM label has been added. DetailsGit tree hash: 84f0c219b81c03a11c000d05fab0fccc4d45b0cf |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klocke-io The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three places in the pipeline ran Hugo-specific logic regardless of the --hugo flag: _index.md rename in FSWriter, HugoStructuralDirs trimming in buildOutputLink, and ReAnchorRootAbsolute in resolveRelativeToAbsolute. All three are now guarded by Hugo.Enabled / f.Hugo.
What this PR does / why we need it:
With
--hugo=false, three Hugo-specific transformations still fired unconditionally:README.mdwas renamed to_index.md, structural directory prefixes were stripped from output links, and root-absolute links were re-anchored using Hugo structural dirs. This fixes all three by gating each behind theHugo.Enabled/f.Hugoflag.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
No behavior change for
--hugo=true(the default). The existing test "hugo structural dir stripped" expected the buggy behavior and has been corrected to reflect the fixed output.Release note: