Skip to content

refactor(writer): move Hugo index-file rename from Writer.Write into DocumentWorker.ProcessNode - #499

Open
VelmiraS wants to merge 1 commit into
masterfrom
refactor/writer-drop-index-names
Open

VelmiraS wants to merge 1 commit into
masterfrom
refactor/writer-drop-index-names

Conversation

@VelmiraS

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Moves the Hugo _index.md rename decision from Writer.Write into DocumentWorker.ProcessNode, so the Writer interface is no longer aware of Hugo-specific logic. No behavior change for users.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The FakeWriter counterfeiter was updated manually (removed arg5 []string). TestWriteHugoIndexRename moved from fswriter_test to document_worker_rename_test.

Release note:

Writer.Write signature drops the IndexFileNames parameter; callers that implement the Writer interface must update their signature.

@VelmiraS
VelmiraS requested a review from klocke-io September 16, 2026 10:53
@VelmiraS VelmiraS self-assigned this Sep 16, 2026
@gardener-prow

gardener-prow Bot commented Sep 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radabdimitrova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant