Repository navigation
Preserve the verified Goal stop receipt when closeout fails - #1
Open
loopx-agent wants to merge 1 commit into
Open
loopx-agent wants to merge 1 commit into
loopx-agent wants to merge 1 commit into
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the stop receipt review on loopx-project/loopx#9065. Once both registries verify the stop, the optional closeout hook uses that same source snapshot. The CLI retains the verified stop receipt even if hook preparation raises, and reports the error separately without echoing raw exception text. The hook still runs outside the registry locks.
All 69 targeted closeout and Goal activation tests passed. Three cases exercise the real stop CLI: an unavailable extra registry read, an unavailable extra read with no configured hook, and a preparation error. Each verifies exit status,
written, and both durable registries. Ruff, mypy, and the public scan of the changed files passed. The full suite was not run on this checkout.