Skip to content

docs: fix example notebook on colab - #1489

Open
psschwei wants to merge 1 commit into
generative-computing:mainfrom
psschwei:fix-example-noteboo
Open

docs: fix example notebook on colab#1489
psschwei wants to merge 1 commit into
generative-computing:mainfrom
psschwei:fix-example-noteboo

Conversation

@psschwei

Copy link
Copy Markdown
Member

Pull Request

Issue

Fixes #335

Description

Installing Ollama on colab requires the zstd package.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code was added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

Adding a new component, requirement, sampling strategy, or tool?

If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.

  • Component
  • Requirement
  • Sampling Strategy
  • Tool

NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei
psschwei requested a review from a team as a code owner July 31, 2026 21:19
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 31, 2026

@ajbozarth ajbozarth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, minimal fix for a real Colab breakage. Approving. Optional nits inline — doesn't block merge.

},
"outputs": [],
"source": [
"!sudo apt-get update && sudo apt-get install -y zstd\n",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two optional nits, neither blocking:

  1. Every other command in this cell suppresses output, so apt-get will stand out as a wall of text. Matching the surrounding style:
Suggested change
"!sudo apt-get update && sudo apt-get install -y zstd\n",
"!sudo apt-get update -qq && sudo apt-get install -y -qq zstd > /dev/null\n",
  1. The markdown cell above ("we download, install and serve ollama") no longer mentions this prerequisite — a few words there would keep the prose in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CoLab - Hello World Quick‑start demo

2 participants