Repository navigation
Conversation
- Issue: The api_url, wms_url and wmts_url params can currently receive any url as values, which means a malicious party could use them as an attack vector. This is especially true for api_url, which can send html back and is needed to operate that way. - Fix: We have made regexes which enfore a whitelist on those parameters As we need external sources html to be rendered (for the feature informations, for example), we sadly can't sanitize the html given to us without breaking a lot of currently working layers. We can only limit the sources and hope they don't provide malicious content.
…some-urls-for-apis PB-2553: stopping XSS attacks by whitelisting
GPS-745: switch to pnpm 11
Keep official attribution sources ahead of local file sources when compacting the footer attribution list. Limit inline attribution entries to four and truncate local imported names so long file labels do not cover the map.
Issue: the local-file attribution compaction could hide non-local primary attribution sources behind the overflow toggle when enough primary sources were active.\n\nSolution: keep every primary source inline and apply the overflow count only to local-file sources that exceed the remaining visible slots.
Issue: the compact attribution summary rendered a comma before the overflow counter.\n\nSolution: mark the last inline attribution as the last item even when the overflow counter is visible.
…erflow-spec PB-2337: compact overflowing map attributions
Replace sequential type checks with a switch so the categorical label color mapping is easier to scan and extend.
Fade labels over the final 24% of their published display distance using Cesium's native translucency scalar.
chore: Update develop from master
Use Cesium tile lifetime instead of per-frame visibility gaps to remove labels. Queue collection changes until postRender and cover the lifecycle with a focused unit test.
Cover layer unmount while the 3D Tiles request is still pending. Verify that the completed tileset is destroyed before any primitives are attached.
PB-2246: render Swissnames labels with standard 3D Tiles
PB-2241: Added labels for v3 of BABS civil signatures
…uring-fade PB-2246: hide label stems when labels begin fading
PB-2246: apply selected Swissnames label styling
Define the Swissnames font and outline tuning values as named constants. Increase the white outline and use the selected darker salmon color for peak labels.
Use a three-pixel outline to improve readability without overwhelming the label glyphs.
Increase the configurable outline width so the data owner can compare the stronger halo in the PR preview.
Change mountain-name labels to RGB 74/74/74 for better readability on aerial imagery.
…-label-style PB-2246: refine Swissnames label styling
ltkum
enabled auto-merge
October 13, 2026 10:56
ltshb
approved these changes
Oct 13, 2026
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 04m 52s |
| Commit |
|
| Committer | Raphi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
222
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link