Repository navigation
PB-2436: load icon images in 3D from their URL - #1602
Merged
Merged
Conversation
Switching to 3D with a GeoJSON layer using icons (e.g. Ladepunkte für Elektroautos) stopped Cesium from rendering. We gave Cesium the OpenLayers icon image before it was loaded (width 0). Cesium now gets the icon URL and loads the image itself.
rotwurstesser
force-pushed
the
fix-3d-icon-billboards
branch
from
October 14, 2026 09:16
6e696bc to
dc35092
Compare
web-mapviewer
 |
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-3d-icon-billboards
|
| Run status |
|
| Run duration | 04m 58s |
| Commit |
|
| Committer | Raphi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
19
|
 |
0
|
 |
222
|
| View all changes introduced in this branch ↗︎ | |
Contributor
Author
|
rotwurstesser
changed the title
rotwurstesser
marked this pull request as ready for review
October 14, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PB-2436
Switching to 3D with a GeoJSON layer using icons (e.g. Ladepunkte für Elektroautos) stops Cesium from rendering. On prod the map just stays black, on int/dev you see "Expected image.width to be greater than or equal to 1".
We gave Cesium the OpenLayers icon image before it was loaded (width 0). Now Cesium gets the icon URL and loads it itself.
Same view side by side, switch to 3D in both:
Test link
Test link
Test link