Skip to content

Apply Swift API Design Guidelines to AtprotoClient - #67

Merged
germ-mark merged 3 commits into
mainfrom
mark/api-guidelines-atprotoclient
Oct 28, 2026
Merged

germ-mark merged 3 commits into
mainfrom
mark/api-guidelines-atprotoclient

Conversation

@germ-mark

@germ-mark germ-mark commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Migrate optional unwrapping and XRPC query parameters to upstream Swift naming.
  • Use rawValue and statusCode for the corresponding values.
  • Pin AtprotoTypes to released version 0.11.0 and GermConvenience to 0.15.0.
  • Add a minor changeset.

Validation

  • swift test --disable-sandbox --cache-path /private/tmp/ger3167-atclient-repin-swiftpm-cache passed (115 tests).
  • swift format lint --recursive --configuration .swift-format --strict Sources Tests Package.swift passed.

— Codex agent

@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ea4e6ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@germ-network/atprotoclient Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@germ-mark
germ-mark marked this pull request as ready for review October 28, 2026 05:45
@germ-mark
germ-mark merged commit 5131e4e into main Oct 28, 2026
22 checks passed
@germ-mark
germ-mark deleted the mark/api-guidelines-atprotoclient branch October 28, 2026 05:57
@github-actions github-actions Bot mentioned this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant