Skip to content

Fix system prune result summary#12

Open
mkaltner wants to merge 2 commits into
mainfrom
fix/system-prune-result-summary
Open

Fix system prune result summary#12
mkaltner wants to merge 2 commits into
mainfrom
fix/system-prune-result-summary

Conversation

@mkaltner

@mkaltner mkaltner commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • report build-cache-only prune results as pruned resources
  • fall back to a positive prune summary when reclaimed bytes are reported without deleted item lists
  • add focused unit coverage for build cache, bytes-only, and empty-result summaries

iOS comparison

  • iOS correctly summarizes non-empty container/image/volume/network prune arrays
  • iOS has a nearby edge case where build-cache-only or bytes-only results can read as "Nothing to remove" while still showing freed bytes
  • this Android fix preserves the normal item-count summary and handles that edge case explicitly

Test plan

  • ANDROID_HOME=/home/nameless1/Android/Sdk ANDROID_SDK_ROOT=/home/nameless1/Android/Sdk ./gradlew --no-daemon :app:testDebugUnitTest :app:assembleDebug

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

This PR fixes how system prune results are summarized in the Android dashboard. The main changes are:

  • Reports build-cache-only prune results as pruned resources.
  • Uses reclaimed bytes to show a positive summary when deleted item lists are empty.
  • Adds focused unit tests for build cache, bytes-only, and empty prune results.

Confidence Score: 5/5

Safe to merge with minimal risk.

The change is narrowly scoped to prune result formatting and includes tests for the new edge cases. No functional or security issues were identified.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • The dashboard prune prereq checks were reviewed and showed missing Java-related setup (no java command, empty JAVA_HOME, and missing Android SDK path).
  • The focused dashboard prune test failed with exit code 1, and Gradle reported that JAVA_HOME is not set and no 'java' command could be found in PATH.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Fix system prune result summary" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant