Fix containers list and activity stream events#38
Closed
mkaltner wants to merge 0 commit into
Closed
Conversation
mkaltner
force-pushed
the
fix/containers-complete-list-activity-stream
branch
from
July 16, 2026 19:43
d21044f to
553816b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchPaginationSort(start = 0, limit = -1)so local search, filter, and sort operate on the complete active-environment container list instead of the server default page.ERROR, and ignoreHEARTBEATlikeUNKNOWN, keeping the existing store flow intact.Verification
git diff --check./gradlew :app:compileDebugKotlin./gradlew :app:testDebugUnitTestDisclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR makes two targeted fixes: it handles the new
ERRORandHEARTBEATactivity stream event kinds inActivityCenterStore, and it switches the containers list call toSearchPaginationSort(start = 0, limit = -1)so that search, filtering, and sorting all operate on the complete server-side list rather than a default-sized page.ERRORnow surfacesevent.error(or a fallback string) asstreamErrorMessage;HEARTBEATis silently ignored alongsideUNKNOWN. Both are consistent with the existingMISSEDhandling pattern.limit = -1is passed tocontainers.list()to request an unbounded result set. This sentinel is not used elsewhere in the codebase, so confirming the SDK accepts it as "return all" would be prudent.Confidence Score: 4/5
The activity-stream changes are clean and safe to merge. The container list change works correctly as long as the SDK accepts -1 as an unbounded-fetch value, which is the only unverified assumption.
Both changes are small and self-contained. The activity-stream event handling follows the established pattern exactly and introduces no risk. The containers change intentionally fetches the full list, but limit = -1 is not corroborated by any other SDK callsite in the codebase, so there is a small open question about whether the backend honours that sentinel.
ContainerListScreen.kt — specifically the limit = -1 parameter passed to containers.list().
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Fix containers list and activity stream ..." | Re-trigger Greptile