Skip to content

Harden complete container loading#41

Merged
mkaltner merged 3 commits into
mainfrom
fix/par-003-container-pagination
Jul 17, 2026
Merged

Harden complete container loading#41
mkaltner merged 3 commits into
mainfrom
fix/par-003-container-pagination

Conversation

@mkaltner

@mkaltner mkaltner commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • retain Arcane's documented limit = -1 show-all container request introduced in Fix Containers tab completeness and activity stream events #39
  • harden complete-list integrity with container-ID deduplication and reported-total validation so partial or inconsistent results are not published
  • propagate coroutine cancellation and extract deterministic filtering/loading-state logic for focused regression coverage
  • record PAR-003 validation evidence and a scoped PAR-004 follow-up for the broader pagination audit

Context

PR #39 already fixed the user-visible first-20 issue by switching the Containers screen to Arcane's documented show-all contract. This PR does not introduce bounded page traversal: the available server sorts do not provide a unique ordering key needed for correctness-preserving offset traversal.

Instead, this follow-up verifies and hardens the existing complete-list behavior. Local search and filters operate only after the intended dataset is confirmed complete, duplicate IDs cannot produce duplicate UI results, inconsistent totals fail without publishing partial content, and cancellation remains structured.

No Kotlin SDK, Arcane server, or Arcane Updates changes are included.

Validation

  • focused pagination tests: 14/14 passed
  • :app:testDebugUnitTest: 98/98 passed
  • :app:assembleDebug: passed
  • git diff --check: passed (Windows line-ending warnings only)

Manual device testing is pending.

@mkaltner
mkaltner marked this pull request as ready for review July 17, 2026 21:44
@mkaltner
mkaltner merged commit fdfabe3 into main Jul 17, 2026
4 checks passed
@mkaltner
mkaltner deleted the fix/par-003-container-pagination branch July 17, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant