fix(ci): move playwright render tests out of the pnpm test glob - #25
Merged
Conversation
The release workflow runs plain pnpm test without a browser install — only CI's test:render step installs Chromium. The ported browser tests belong with that step: test/render/render.test.mjs, script updated. Mirrors the pre-1.1.0 layout where render tests lived outside the engine glob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow runs plain
pnpm testwithout a browser install — only CI'stest:renderstep installs Chromium. The 1.1.0 port put the browser tests inside the engine glob, failing the v1.1.0 release run. Moves them totest/render/render.test.mjs(test:render updated), mirroring the pre-1.1.0 layout where render tests lived outside the glob.