fix(init): rotate spinner messages during long plan-codemods wait#1108
Open
jared-outpost[bot] wants to merge 2 commits into
Open
fix(init): rotate spinner messages during long plan-codemods wait#1108jared-outpost[bot] wants to merge 2 commits into
jared-outpost[bot] wants to merge 2 commits into
Conversation
During plan-codemods, the spinner showed static text for up to ~3min while the server fetched SDK docs and ran the planner agent. Users assumed the CLI had hung and bailed. Add client-side rotating progress messages that cycle every 12s during resumeWithRecovery() for steps with known long waits (plan-codemods, detect-platform). After exhausting all messages, append elapsed time so the user knows the system is still working. Fixes #1107
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 89.29%. Project has 5041 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.23% 81.23% —%
==========================================
Files 386 386 —
Lines 26831 26858 +27
Branches 17427 17439 +12
==========================================
+ Hits 21795 21817 +22
- Misses 5036 5041 +5
- Partials 1810 1814 +4Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 30115b2. Configure here.
The rotation timer could overwrite 'Reconnecting...' spinner messages during stale-step or connection recovery. Add pause/resume to the rotation handle so resumeWithRecovery can suppress ticks while recovery is in progress.
Contributor
Author
|
all CI checks are green. skipping auto-merge since the diff is 363 lines across 4 files (exceeds the 150-line threshold for autonomous merge) — leaving for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
plan-codemods, the spinner showed static text ("Planning code changes...") for up to ~3 minutes while the server fetched SDK docs and ran the planner agent, causing users to bail. This adds client-side rotating progress messages that cycle every 12s duringresumeWithRecovery()for steps with known long waits (plan-codemods,detect-platform). After exhausting all messages, elapsed time is appended so the user knows the system is still working.No regression in
LoggingUI— the spinner'smessage()method logs each rotation as a separate line in non-interactive mode, which is the desired behavior.Testing
vitest run test/lib/init/clack-utils.test.ts— 15/15 pass (4 new tests for progress message constants)wizard-runner.test.tshas a pre-existing Stricli alias conflict (-Hinlocal/server.ts) that prevents it from loading; 3 new tests added for the rotation behaviorbiome checkclean on all changed filesCloses #1107